Issue 5676: Introduced the option to fall back to TCP when DNS resolv…#5692
Open
cgm-aw wants to merge 1 commit intoeclipse-vertx:4.xfrom
Open
Issue 5676: Introduced the option to fall back to TCP when DNS resolv…#5692cgm-aw wants to merge 1 commit intoeclipse-vertx:4.xfrom
cgm-aw wants to merge 1 commit intoeclipse-vertx:4.xfrom
Conversation
Member
|
I think we are missing a test for this |
vietj
force-pushed
the
feature/4.x-issue-5676-tcp-dns
branch
from
4455154 to
733e100
Compare
Author
|
I thought about testing this, but all Vertx does here is pass the parameter to the Netty resolver. So I just tested this new functionality. Writing a test which checks whether the fallback actually works is out of scope here from my point of view, and I think it would require a lot of mocking and/or dependencies to Netty internals, which would make the test hard to maintain. |
…ing via UDP fails with a timeout
vietj
force-pushed
the
feature/4.x-issue-5676-tcp-dns
branch
from
733e100 to
73a0cd6
Compare
Member
|
@cgm-aw can you sign the Eclipse Contributor Agreement |
Author
|
Sure, you can find me under "cgmaw" |
Member
|
vertx has a mock dns resolver we can use
…On Thu, Sep 4, 2025 at 8:45 AM Andreas ***@***.***> wrote:
*cgm-aw* left a comment (eclipse-vertx/vert.x#5692)
<#5692 (comment)>
I thought about testing this, but all Vertx does here is pass the
parameter to the Netty resolver. So I just tested this new functionality.
Writing a test which checks whether the fallback actually works is out of
scope here from my point of view, and I think it would require a lot of
mocking and/or dependencies to Netty internals, which would make the test
hard to maintain.
Let me know if you still want a test to test the actual fallback in Netty
and I will give it a shot.
—
Reply to this email directly, view it on GitHub
<#5692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCUPPRHQYG5MK5C6FYT3Q7N2DAVCNFSM6AAAAACFKQEJWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJSGE3DGOJZGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5676